1

Which is one grammatically correct?

  1. After I got my car repaired, I noticed it started to make funny noises which it had not made before/ which I had not heard before.

  2. After I got my car repaired, I noticed it started to make funny noises which it has not made before / which I have not heard before.

1

It is more of a logic problem...

The funny noises were not heard during the period of time before the car was repaired. But since this period of time ended (with the car repair), you should use past perfect regarding conditions (or lack of) during that time.

1) After I got my car repaired, I noticed it started to make funny noises which it had not made before/which I had not heard before.

On the side, I think it is more natural to use making in place of to make.

1

After I got my car repaired, I noticed it started to make funny noises which it had not made before/ which I had not heard before.
After I got my car repaired, I noticed it started to make funny noises which it has not made before / which I have not heard before.

The function of tense shifts in situations like this is either to establish or to corroborate a Reference Time. If other temporal elements of the sentence already do this, then all of the responsibility no longer rests on the shoulders of the verb tense. The verb tense can corroborate--if corroboration is deemed necessary for the sake of clarity. Speech is communication, after all, not a programming language.

Since other temporal elements of the sentence establish the reference time ("After I got my car fixed it started to make funny noises..." ) you are free to say either ...which it had not made before or ...which it has not made before.

Are there situations where you would choose the one over the other? Yes.

If you are speaking to the mechanic who made the repair yesterday, you might say "funny noises which it has not made before" to emphasize the fact that from the day you bought the car up until the present repair, it has never made these funny sounds.

If you are suing the mechanic in a court of law for ruining your car, and the repair occurred eighteen months ago, and your case has only now come before the court, then you need to refer to two times in the past, and you would probably say to the judge, "the car made funny noises which it had not made before the repair."

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service, privacy policy and cookie policy

Not the answer you're looking for? Browse other questions tagged or ask your own question.